Skip to content

Conversation

marmeladema
Copy link
Contributor

@marmeladema marmeladema commented Jun 11, 2020

Fixes #61385

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2020
@marmeladema
Copy link
Contributor Author

r? @Xanewok

@marmeladema marmeladema force-pushed the save-analysis-various-fixes branch from 0352177 to 0e811d0 Compare June 11, 2020 18:12
@bors
Copy link
Collaborator

bors commented Jun 19, 2020

☔ The latest upstream changes (presumably #73486) made this pull request unmergeable. Please resolve the merge conflicts.

@Xanewok
Copy link
Member

Xanewok commented Jun 19, 2020

Sorry for the delay, r=me once rebased

@marmeladema marmeladema force-pushed the save-analysis-various-fixes branch from 0e811d0 to 0e31380 Compare June 19, 2020 09:36
@marmeladema
Copy link
Contributor Author

@Xanewok rebased and fixed conflicts 👍

@Xanewok
Copy link
Member

Xanewok commented Jun 19, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 19, 2020

📌 Commit 0e31380 has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2020
@Xanewok
Copy link
Member

Xanewok commented Jun 19, 2020

Thank you!

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2020
…arth

Rollup of 13 pull requests

Successful merges:

 - rust-lang#71568 (Document unsafety in slice/sort.rs)
 - rust-lang#72709 (`#[deny(unsafe_op_in_unsafe_fn)]` in liballoc)
 - rust-lang#73214 (Add asm!() support for hexagon)
 - rust-lang#73248 (save_analysis: improve handling of enum struct variant)
 - rust-lang#73257 (ty: projections in `transparent_newtype_field`)
 - rust-lang#73261 (Suggest `?Sized` when applicable for ADTs)
 - rust-lang#73300 (Implement crate-level-only lints checking.)
 - rust-lang#73334 (Note numeric literals that can never fit in an expected type)
 - rust-lang#73357 (Use `LocalDefId` for import IDs in trait map)
 - rust-lang#73364 (asm: Allow multiple template string arguments; interpret them as newline-separated)
 - rust-lang#73382 (Only display other method receiver candidates if they actually apply)
 - rust-lang#73465 (Add specialization of `ToString for char`)
 - rust-lang#73489 (Refactor hir::Place)

Failed merges:

r? @ghost
@bors bors merged commit 186640a into rust-lang:master Jun 20, 2020
@marmeladema marmeladema deleted the save-analysis-various-fixes branch April 24, 2021 09:11
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In save-analysis, enum struct variant constructions aren't being recorded
6 participants